👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shohag121! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Looks good to me; thanks for the contribution.

Hi @ellatrix,

Is there anything that this PR needs as an improvement?
Your feedback is much appreciated.

Thanks.

Looks like you need to rebuild docs. This can be done with npm run docs:build.

Ran npm run docs:build as you instructed but it did not generate manifest.json.
As I did not add any new file, only updated one maybe that's why it is failing at Static Analysis (Linting, License, Type checks...)? (Got the hint from Documentation Contributions Gide)

Got this output at console

Thanks.

@shohag121 The npm run docs:build command will run node ./bin/api-docs/update-api-docs.js and that is resetting your change.

You can confirm by running that command by itself and then do a git status or git diff and see.

The reason it is doing that is because that part of the README.md is auto generated from the source files. To update, you need to update the comments in:

• packages\dom\src\dom\document-has-text-selection.js
• packages\dom\src\dom\document-has-uncollapsed-selection.js

After you update the code comments in those files then run npm run docs:build and it should show the README.md updated properly. Commit that and we should be good to go.

Let me know if that makes sense or if you have additional questions.